Finish implementing new transacitions

application/connection.py

@@ -169,20 +169,38 @@ def update_account(account_id, otp_code:int, description=None, notes=None):
         print(f"RequestException: {e}")
         return {'success': False, 'message': "Could not connect to the server. Please try again later."}
 
-def new_transaction(ammount, account_id, recipient_account_id, otp_code, description):
+def new_transaction(account_id, description, amount, recipient_account_id, otp_code):
     """Creates a new transaction for the given account."""
     try:
         with open('application\\session_data.json', 'r') as f:
             session_data = json.load(f)
-        if description == "":
-            description = None
-        params = {"account_id": account_id, "recipient_account_id": recipient_account_id, "amount": ammount, "description": description, "otp_code": otp_code}
+        # Prepare the query parameters
+        params = {
+            "amount": amount,
+            "account_id": account_id,
+            "recipient_account_id": recipient_account_id,
+            "otp_code": otp_code,
+            "description": description}
+        print(f"Params: {params}")
         response = requests.post(CONFIG["server"]["url"] + "/Transaction", cookies=session_data['session_cookie'], params=params)
         response.raise_for_status()
+        print(f"Response: {response.json()}")
         return response.json()
+    except requests.exceptions.HTTPError as e:
+        if e.response.status_code == 404:
+            return {'success': False, 'message': 'Account not found.'}
+        elif e.response.status_code == 403:
+            return {'success': False, 'message': 'Invalid OTP code.'}
+        elif e.response.status_code == 400:
+            return {'success': False, 'message': 'Invalid request. Please check the OTP code and other details.'}
+        else:
+            print(f"HTTPError: {e}")
+            return {'success': False, 'message': f"Unexpected error occurred. Error: {e}"}
+
     except requests.exceptions.RequestException as e:
         print(f"RequestException: {e}")
-        return {'success': False, 'message': "Could not connect to the server. Please try again later."}
+        return {'success': False, 'message': f"Could not connect to the server. Error: {e}"}
+
 
 def generate_otp():
     """Generates a new OTP for the current client, which is sent by Email."""

application/new_transaction.py

@@ -24,64 +24,64 @@ else:
 
 def submit_transaction():
     """Submit a new transaction to the server."""
-    account_id = account_combobox.get()
-    recipient_id = recipient_text.get("1.0", "end-1c")
-    amount = amount_text.get("1.0", "end-1c")
-    description = description_text.get("1.0", "end-1c")
-
-    if not amount or not recipient_id or not account_id:
-        messagebox.showerror("Error", "Please fill in all fields.")
+    amount = amount_text.get("1.0", "end").strip()
+    account_id = account_combobox.get().strip()
+    recipient_id = recipient_text.get("1.0", "end").strip()
+    description = description_text.get("1.0", "end").strip()
+    otp_code:int = otp_text.get("1.0", "end").strip()
+    if not amount or not recipient_id or not account_id or not otp_code: 
+        messagebox.showerror("Error", "Please fill in manditory fields.")
         return
-
-    # Convert amount to float
-    try:
+    if verify_accounts(account_id, recipient_id, amount) is False:
+        return
+    if not otp_code.isdigit() or len(otp_code) != 6:
+        messagebox.showerror("Error", "Please enter a valid 6-digit OTP code.")
+        return    
+    try: # Convert amount to float
         amount = float(amount)
     except ValueError:
         messagebox.showerror("Error", "Invalid amount entered.")
         return
-
-    account_verification = verify_accounts()
-    if account_verification is False:
-        messagebox.showerror("Error", "Could not verify account IDs.")
+    try: # Convert otp code to int
+        otp_code = int(otp_code)
+    except ValueError:
+        messagebox.showerror("Error", "Invalid OTP code entered.")
         return
 
-    response = new_transaction(account_id, description, amount, recipient_id)
-    if response is None or "data" not in response:
+    response = new_transaction(account_id, description, amount, recipient_id, otp_code)
+    if response is None or "success" not in response:
         messagebox.showerror("Error", "Could not submit transaction.")
         return
 
-    transaction_id = response["data"]
-    otp = generate_otp(account_id, transaction_id)
-    if otp is None or "data" not in otp:
-        messagebox.showerror("Error", "Could not generate OTP.")
+    if not response['success']:  # Check if the transaction was unsuccessful
+        messagebox.showerror("Error", response['message'])  # Show the error message in a popup
         return
 
-    messagebox.showinfo("Success", f"Transaction submitted successfully. OTP: {otp['data']}")
+    if response['success']:  # Check if the transaction was successful
+        messagebox.showinfo("Success", "Transaction submitted successfully.")
+        root.destroy()  # Close the window
+        return
 
-def verify_accounts():
-    """Verify that the account IDs are valid."""
-    try:
-        account_id = account_combobox.get()
-        recipient_id = recipient_text.get("1.0", "end-1c")
-        account = get_account(account_id)
-        recipient_id = get_account(recipient_id)
-    except requests.exceptions.RequestException as e:
-        messagebox.showerror("Error", f"Failed to get account details: {e}")
+
+def verify_accounts(account_id, recipient_id, amount):
+    """Verify that both account IDs are valid, and the from account has enough balance to make the transaction."""
+    account = get_account(account_id)
+    if account is None or "data" not in account or "balance" not in account["data"]:
+        messagebox.showerror("Error", "Invalid account ID.")
         return False
-    if account is None or recipient_id is None or "data" not in account or "data" not in recipient_id:
-        messagebox.showerror("Error", "Server did not return the expected response.")
+    recipient = get_account(recipient_id)
+    if recipient is None or "data" not in recipient:
+        messagebox.showerror("Error", "Invalid recipient ID.")
         return False
-    if "account_id" not in account["data"]:
-        messagebox.showerror("Error", "Account ID not found.")
+    try: # Convert amount to float
+        amount = float(amount)
+    except ValueError:
+        messagebox.showerror("Error", "Invalid amount entered.")
         return False
-    if "account_id" not in recipient_id["data"]:
-        messagebox.showerror("Error", "Recipient Account ID not found.")
-        return False
-    amount = amount_text.get("1.0", "end-1c")
-    if account["data"]["balance"] < amount: # Check the client has the required balance
-        messagebox.showerror("Error", "Insufficient funds.")
-        return False
-    messagebox.showinfo("Success", "Accounts verified successfully.")
+    account_balance = account["data"]["balance"]
+    if account_balance < amount:
+        messagebox.showerror("Error", "Insufficient balance.")
+        return False 
     return True
 
 def populate_accounts(client_id):
@@ -156,7 +156,7 @@ otp_text = customtkinter.CTkTextbox(root, height=2, width=250)
 otp_text.pack(pady=5)
 
 # Create the submit button
-submit_button = customtkinter.CTkButton(root, text="Submit", command=submit_transaction)
+submit_button = customtkinter.CTkButton(root, text="Verify & Submit", command=submit_transaction)
 submit_button.pack(pady=5)
 
 # Populate accounts combobox with the given client_id

application/session_data.json

@@ -1 +1 @@
-{"session_cookie": {"session": "0vm2PELvoXxLiOtpdLDR6M4-WHJq5xq5BX92b46UTkM"}, "client_id": "9755c18f"}
+{"session_cookie": {"session": "I5vE6-7HHC9fAildRSp-bxrPKTaglz4CWQgh1fdoFE4"}, "client_id": "9755c18f"}